Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raw output data config object #146

Merged
merged 10 commits into from
Aug 12, 2020
Merged

Raw output data config object #146

merged 10 commits into from
Aug 12, 2020

Conversation

wild-endeavor
Copy link
Contributor

@wild-endeavor wild-endeavor commented Jul 30, 2020

TL;DR

Please see the issue.

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Complete description

  • Included some minor changes to make python 3.8 mostly work, which I was using locally.

Tracking Issue

flyteorg/flyte#211

Follow-up issue

NA

@wild-endeavor wild-endeavor changed the title wip - Output prefix Raw output data config object Jul 31, 2020
@codecov-commenter
Copy link

codecov-commenter commented Jul 31, 2020

Codecov Report

Merging #146 into master will increase coverage by 0.07%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #146      +/-   ##
==========================================
+ Coverage   80.88%   80.95%   +0.07%     
==========================================
  Files         225      225              
  Lines       14669    14716      +47     
  Branches     1204     1205       +1     
==========================================
+ Hits        11865    11914      +49     
+ Misses       2521     2519       -2     
  Partials      283      283              
Impacted Files Coverage Δ
flytekit/__init__.py 100.00% <100.00%> (ø)
flytekit/common/launch_plan.py 76.61% <100.00%> (+0.98%) ⬆️
flytekit/common/utils.py 80.00% <100.00%> (+1.05%) ⬆️
flytekit/common/workflow.py 75.00% <100.00%> (+0.14%) ⬆️
flytekit/configuration/auth.py 100.00% <100.00%> (ø)
flytekit/models/common.py 94.47% <100.00%> (+0.32%) ⬆️
flytekit/models/launch_plan.py 82.82% <100.00%> (+0.53%) ⬆️
...sts/flytekit/unit/common_tests/test_launch_plan.py 100.00% <100.00%> (ø)
tests/flytekit/unit/models/test_common.py 100.00% <100.00%> (ø)
tests/flytekit/unit/models/test_launch_plan.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8d557a0...9e25846. Read the comment docs.

@EngHabu
Copy link
Collaborator

EngHabu commented Aug 12, 2020

Verified flytekit serialize and register produce the right outputs and Admin persists the config.

@EngHabu
Copy link
Collaborator

EngHabu commented Aug 12, 2020

@EngHabu EngHabu merged commit 74a8163 into master Aug 12, 2020
max-hoffman pushed a commit to dolthub/flytekit that referenced this pull request May 11, 2021
* add raw output data prefix

* wip

* updating

* use the object now

* setup

* wip

Co-authored-by: Haytham AbuelFutuh <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants