Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade a couple of deps #275

Merged
merged 1 commit into from
Dec 28, 2023
Merged

Upgrade a couple of deps #275

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,14 +95,14 @@
module that uses @AutoService, otherwise we get warning like "The following options were not recognized by any processor: '[verify]'",
which again will fail the build because we have failOnWarning.
-->
<auto-service.version>1.0.2</auto-service.version>
<auto-service.version>1.1.1</auto-service.version>
<auto-value.version>1.10.4</auto-value.version>
<common-proto.version>2.29.0</common-proto.version>
<grpc.version>1.59.1</grpc.version>
<!-- must be aligned with netty version -->
<!-- see: https://github.com/grpc/grpc-java/blob/master/SECURITY.md#netty -->
<netty.tcnative.version>2.0.52.Final</netty.tcnative.version>
<picocli.version>4.7.2</picocli.version>
<picocli.version>4.7.5</picocli.version>
<protobuf.version>3.25.1</protobuf.version>
<sl4j.version>1.7.36</sl4j.version>
<!-- also remember to bump the version in flytekit-bom module -->
Expand All @@ -119,8 +119,8 @@
<maven.compiler.source>${maven.compiler.release}</maven.compiler.source>
<maven.compiler.target>${maven.compiler.release}</maven.compiler.target>
<mockito.version>3.3.3</mockito.version>
<scala212.version>2.12.17</scala212.version>
<scala213.version>2.13.10</scala213.version>
<scala212.version>2.12.18</scala212.version>
<scala213.version>2.13.12</scala213.version>
<magnolia.version>1.0.0-M4</magnolia.version>
</properties>

Expand Down Expand Up @@ -444,7 +444,6 @@
<showWarnings>true</showWarnings>
<showDeprecation>true</showDeprecation>
<forceJavacCompilerUse>true</forceJavacCompilerUse>
<failOnWarning>true</failOnWarning>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a hard decision. See google/auto#870. It makes no sense to add @SuppressWarnings("rawtype") everywhere in the code base, and it is more dangerous to set -Averify=false (plus I barely got it working; it worked in one module but not in another and I had no clue why).

<!-- The semantics of this option are reversed, see MCOMPILER-209. -->
<useIncrementalCompilation>false</useIncrementalCompilation>
<encoding>utf-8</encoding>
Expand Down
Loading