Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies #274

Merged
merged 1 commit into from
Dec 20, 2023
Merged

Update dependencies #274

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 13 additions & 8 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,18 +97,18 @@
-->
<auto-service.version>1.0.2</auto-service.version>
<auto-value.version>1.10.4</auto-value.version>
<common-proto.version>2.14.3</common-proto.version>
<grpc.version>1.46.0</grpc.version>
<common-proto.version>2.29.0</common-proto.version>
<grpc.version>1.59.1</grpc.version>
<!-- must be aligned with netty version -->
<!-- see: https://github.com/grpc/grpc-java/blob/master/SECURITY.md#netty -->
<netty.tcnative.version>2.0.52.Final</netty.tcnative.version>
<picocli.version>4.7.2</picocli.version>
<protobuf.version>3.21.12</protobuf.version>
<protobuf.version>3.25.1</protobuf.version>
<sl4j.version>1.7.36</sl4j.version>
<!-- also remember to bump the version in flytekit-bom module -->
<spotless.version>2.21.0</spotless.version>
<spotbugs.excludeFilterFile>spotbugs-exclude.xml</spotbugs.excludeFilterFile>
<error_prone.version>2.22.0</error_prone.version>
<error_prone.version>2.23.0</error_prone.version>
<junit.version>5.7.0</junit.version>

<!-- has to be one liner, or errorprone doesn't work -->
Expand Down Expand Up @@ -211,7 +211,7 @@
<dependency>
<groupId>com.google.guava</groupId>
<artifactId>guava</artifactId>
<version>32.1.2-jre</version>
<version>32.1.3-jre</version>
</dependency>
<dependency>
<groupId>io.grpc</groupId>
Expand Down Expand Up @@ -290,6 +290,11 @@
<artifactId>picocli</artifactId>
<version>${picocli.version}</version>
</dependency>
<dependency>
<groupId>junit</groupId>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need this? Because of checker-qual?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not

[WARNING] Rule 1: org.apache.maven.plugins.enforcer.RequireUpperBoundDeps failed with message:
Failed while enforcing RequireUpperBoundDeps. The error(s) are [
Require upper bound dependencies error for junit:junit:4.13 paths to dependency are:
+-org.flyte:jflyte-utils:0.4.38-SNAPSHOT
  +-org.junit.vintage:junit-vintage-engine:5.7.0
    +-junit:junit:4.13
and
+-org.flyte:jflyte-utils:0.4.38-SNAPSHOT
  +-io.grpc:grpc-testing:1.59.1
    +-junit:junit:4.13.2
]

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, OK, it's part of grpc.

<artifactId>junit</artifactId>
<version>4.13.2</version>
</dependency>
<dependency>
<groupId>org.junit.jupiter</groupId>
<artifactId>junit-jupiter</artifactId>
Expand Down Expand Up @@ -369,7 +374,7 @@
<dependency>
<groupId>org.checkerframework</groupId>
<artifactId>checker-qual</artifactId>
<version>3.33.0</version>
<version>3.40.0</version>
</dependency>
<dependency>
<groupId>net.java.dev.jna</groupId>
Expand All @@ -379,14 +384,14 @@
<dependency>
<groupId>com.fasterxml.jackson</groupId>
<artifactId>jackson-bom</artifactId>
<version>2.14.2</version>
<version>2.16.0</version>
<type>pom</type>
<scope>import</scope>
</dependency>
<dependency>
<groupId>com.google.cloud</groupId>
<artifactId>libraries-bom</artifactId>
<version>25.4.0</version>
<version>26.28.0</version>
<type>pom</type>
<scope>import</scope>
</dependency>
Expand Down
Loading