Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add scala subworkflow ex #208

Merged
merged 1 commit into from
Mar 10, 2023
Merged

Add scala subworkflow ex #208

merged 1 commit into from
Mar 10, 2023

Conversation

sonjaer
Copy link
Contributor

@sonjaer sonjaer commented Mar 10, 2023

TL;DR

We have subworkflow example in java, but not in scala

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Complete description

Adding a scala example so users can see how to write workflows using subworkflows.

@sonjaer sonjaer changed the title add scala subworkflow ex Add scala subworkflow ex Mar 10, 2023
Signed-off-by: Sonja Ericsson <[email protected]>
@sonjaer sonjaer force-pushed the add-sub-workflow-example branch from 2cb3f85 to cc03123 Compare March 10, 2023 08:07
@honnix
Copy link
Member

honnix commented Mar 10, 2023

Please update the PR description.

I don't know details how subworkflow is done in flytekit-java, but this looks valid. :)

@sonjaer sonjaer merged commit 2aaab0b into master Mar 10, 2023
@sonjaer sonjaer deleted the add-sub-workflow-example branch March 10, 2023 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants