Add toSdkBindingDataMap() to SdkType #177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
narape
reviewed
Jan 23, 2023
flytekit-jackson/src/test/java/org/flyte/flytekit/jackson/JacksonSdkTypeTest.java
Outdated
Show resolved
Hide resolved
flytekit-jackson/src/test/java/org/flyte/flytekit/jackson/JacksonSdkTypeTest.java
Outdated
Show resolved
Hide resolved
andresgomezfrr
force-pushed
the
add-toSdkBindingDataMap
branch
from
356260c to
cdd95a0
Compare
Signed-off-by: Andres Gomez Ferrer <[email protected]>
Signed-off-by: Andres Gomez Ferrer <[email protected]>
Signed-off-by: Andres Gomez Ferrer <[email protected]>
andresgomezfrr
force-pushed
the
add-toSdkBindingDataMap
branch
from
cdd95a0 to
42cc298
Compare
andresgomezfrr
changed the title
2 tasks
narape
approved these changes
Jan 24, 2023
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Add a new method into the SdkType interface to allow to transform of an input/output class in a
Map<String, SdkBindingData<?>>Type
Are all requirements met?
Complete description
Add a new method into the SdkType interface to allow to transform an input/output class in a Map<String, SdkBindingData<?>>
This PR also adds their implementations (JacksonSdkType, SdkScalaType)
Tracking Issue
Follow-up issue
NA