Add cache support for Sdk{Runnable|Container}Tasks #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: kiarash rezahanjani <[email protected]>
to make them more with other properties, they follow the javabeans naming convention Signed-off-by: Nelson Arapé <[email protected]>
cache -> discoverable cacheVersion -> discoveryVersion Signed-off-by: Nelson Arapé <[email protected]>
Null are more natural default value in Java than empty string. Make the null <-> "" conversion at the ProtoUtil boundary Signed-off-by: Nelson Arapé <[email protected]>
Signed-off-by: Nelson Arapé <[email protected]>
By introducing a common super interface to RunnableTask and ContainerTask Signed-off-by: Nelson Arapé <[email protected]>
Signed-off-by: Nelson Arapé <[email protected]>
|
Supersedes #121 |
Signed-off-by: Nelson Arapé <[email protected]>
Signed-off-by: Nelson Arapé <[email protected]>
narape
force-pushed
the
task-cache-support
branch
from
9047492 to
938a7a4
Compare
Signed-off-by: Nelson Arapé <[email protected]>
|
@kiarash-rezahanjani I took your PR and expanded. I renamed some things and also added cache to |
lupasarin
approved these changes
Jul 28, 2022
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Add support for caching
SdkRunnableTaskandSdkContainerTaskType
Are all requirements met?
Complete description
The attributes:
Where added to
SdkRunnableTaskandSdkContainerTask, TheProjectClosureis modified to propagate these properties to TaskTemplate and finally ProtoUtil was also modified to translate from (api) TaskTemplate to proto TaskTemplate. The propertiesisCachedandgetCacheVersionwhere renamed in TaskTemplate todiscoverableanddiscoveryVersionto match the one in proto TaskTemplate.Finally the examples were modified to add caching.