This repository has been archived by the owner on Oct 9, 2023. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Prafulla Mahindrakar [email protected]
TL;DR
During testing of the project-domain setting for workflow execution config discovered that UI passes empty security context
This causes the workflow execution config to be picked from this empty context which causes the executions to be launched using default service account which is incorrect since it should have checked further in launchplan spec , matchable attribute , application config in that order.
This PR fixes the issue by doing a deep check on the security context.
Type
Are all requirements met?
Complete description
How did you fix the bug, make the feature etc. Link to any design docs etc
Tracking Issue
flyteorg/flyte#2070
Follow-up issue
NA