Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update mocks in async package to mockery v2 generated mocks #6220

Merged
merged 3 commits into from
Feb 4, 2025
Merged

update mocks in async package to mockery v2 generated mocks #6220

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b12cfdc
update mocks in async package to mockery v2 generated mocks
popojk Feb 4, 2025
e3f200b
fix race condition
popojk Feb 4, 2025
8875d98
delete debugging code
popojk Feb 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion flyteadmin/pkg/async/cloudevent/interfaces/publisher.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import (
"github.com/golang/protobuf/proto"
)

//go:generate mockery -name=Publisher -output=../mocks -case=underscore
//go:generate mockery-v2 --name=Publisher --output=../mocks --case=underscore --with-expecter

// Publisher Defines the interface for Publishing execution event to other services (AWS pub/sub, Kafka).
type Publisher interface {
Expand Down
2 changes: 1 addition & 1 deletion flyteadmin/pkg/async/cloudevent/interfaces/sender.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import (
cloudevents "github.com/cloudevents/sdk-go/v2"
)

//go:generate mockery -name=Sender -output=../mocks -case=underscore
//go:generate mockery-v2 --name=Sender --output=../mocks --case=underscore --with-expecter

// Sender Defines the interface for sending cloudevents.
type Sender interface {
Expand Down
68 changes: 53 additions & 15 deletions flyteadmin/pkg/async/cloudevent/mocks/publisher.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

68 changes: 53 additions & 15 deletions flyteadmin/pkg/async/cloudevent/mocks/sender.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion flyteadmin/pkg/async/events/interfaces/node_execution.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import (
"github.com/flyteorg/flyte/flyteidl/gen/pb-go/flyteidl/admin"
)

//go:generate mockery -name=NodeExecutionEventWriter -output=../mocks -case=underscore
//go:generate mockery-v2 --name=NodeExecutionEventWriter --output=../mocks --case=underscore --with-expecter

type NodeExecutionEventWriter interface {
Run()
Expand Down
2 changes: 1 addition & 1 deletion flyteadmin/pkg/async/events/interfaces/workflow_execution.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import (
"github.com/flyteorg/flyte/flyteidl/gen/pb-go/flyteidl/admin"
)

//go:generate mockery -name=WorkflowExecutionEventWriter -output=../mocks -case=underscore
//go:generate mockery-v2 --name=WorkflowExecutionEventWriter --output=../mocks --case=underscore --with-expecter

type WorkflowExecutionEventWriter interface {
Run()
Expand Down
79 changes: 78 additions & 1 deletion flyteadmin/pkg/async/events/mocks/node_execution_event_writer.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading
Loading