-
Notifications
You must be signed in to change notification settings - Fork 688
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update plugin contribution guidelines #6212
base: master
Are you sure you want to change the base?
Update plugin contribution guidelines #6212
Conversation
Signed-off-by: davidmirror-ops <[email protected]>
Code Review Agent Run #8f92d5Actionable Suggestions - 0Review Details
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6212 +/- ##
==========================================
- Coverage 37.01% 36.90% -0.12%
==========================================
Files 1317 1317
Lines 132523 134061 +1538
==========================================
+ Hits 49060 49479 +419
- Misses 79217 80289 +1072
- Partials 4246 4293 +47
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
awesome, thanks!
Before we merge this though we will need a few changes in flytekit, specifically to implement this idea of having a contrib
submodule. We can dry-run this with one of our old integrations (just so we can make sure it works and people have a model to use as a base), maybe https://github.com/flyteorg/flytekit/tree/master/plugins/flytekit-sqlalchemy?
Tracking issue
Why are the changes needed?
Implement community plugins RFC by updating plugin contribution guidelines
What changes were proposed in this pull request?
How was this patch tested?
Labels
Please add one or more of the following labels to categorize your PR:
This is important to improve the readability of release notes.
Setup process
Screenshots
Check all the applicable boxes
Related PRs
Docs link
Summary by Bito
Documentation update that introduces new guidelines for community plugin contributions. The changes implement the community plugins RFC by adding detailed instructions for integration contributions. This enhancement aims to streamline the process for community members to contribute integrations to the project.Unit tests added: False
Estimated effort to review (1-5, lower is better): 1