-
Notifications
You must be signed in to change notification settings - Fork 684
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP][Flyteadmin] Add variablemap in dataproxy for dataclass/pydantic #6136
[WIP][Flyteadmin] Add variablemap in dataproxy for dataclass/pydantic #6136
Conversation
Signed-off-by: mao3267 <[email protected]>
Signed-off-by: mao3267 <[email protected]>
Code Review Agent Run Status
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6136 +/- ##
==========================================
- Coverage 37.06% 37.05% -0.02%
==========================================
Files 1318 1319 +1
Lines 132638 132763 +125
==========================================
+ Hits 49157 49190 +33
- Misses 79231 79321 +90
- Partials 4250 4252 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: mao3267 <[email protected]>
…taproxy-dataclass-variablemap
Code Review Agent Run Status
|
this is low priority and we should close it, sorry for telling you to do it. |
Current Problem
There are two main components to manage when retrieving the
variable_map
in the Dataproxy'sGetData
function:GetDataFromNodeExecution
andGetDataFromTaskExecution
. Since thevariable_map
resides in theTaskClosure
, it is logical to retrieve it from the Task Repository using the Task's identification details (ID, project, domain, and version).However, I am unable to determine how to access the output from node execution. Is there a way to retrieve the
TaskClosure
(orTask
) directly from theNodeExecution
?Tracking issue
#6081
Why are the changes needed?
While the task input/output is represented as a dataclass or Pydantic model, using the get function to fetch the FlyteRemote execution output will fail due to the absence of the variable_map information. To address this issue, we aim to provide the input/output variable_map through the Dataproxy as a solution.
What changes were proposed in this pull request?
GetData
from dataproxy service.How was this patch tested?
TODO
Setup process
Screenshots
TODO
Check all the applicable boxes
Related PRs
flyteorg/flytekit#3031
Docs link
TODO