Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] Align Note with the Output Naming Convention #5919

Conversation

JiangJiaWei1103
Copy link
Contributor

@JiangJiaWei1103 JiangJiaWei1103 commented Oct 26, 2024

Why are the changes needed?

To better align the note in the tasks page with the actual naming convention of output variables.

What changes were proposed in this pull request?

Change the default name of output variables from outx to ox, where x is an ordinal number starting from 0.

Screenshot 2024-10-26 at 12 18 35 PM

Related Doc Section

https://docs.flyte.org/en/latest/user_guide/basics/named_outputs.html

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All commits are signed-off.

Docs link

https://flyte--5919.org.readthedocs.build/en/5919/user_guide/basics/tasks.html

Copy link

codecov bot commented Oct 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 36.84%. Comparing base (13b3d82) to head (d18c3c7).
Report is 150 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5919   +/-   ##
=======================================
  Coverage   36.84%   36.84%           
=======================================
  Files        1309     1309           
  Lines      130967   130967           
=======================================
+ Hits        48252    48253    +1     
+ Misses      78531    78530    -1     
  Partials     4184     4184           
Flag Coverage Δ
unittests-datacatalog 51.58% <ø> (ø)
unittests-flyteadmin 54.12% <ø> (ø)
unittests-flytecopilot 11.73% <ø> (ø)
unittests-flytectl 62.40% <ø> (ø)
unittests-flyteidl 6.92% <ø> (ø)
unittests-flyteplugins 53.64% <ø> (ø)
unittests-flytepropeller 43.00% <ø> (ø)
unittests-flytestdlib 55.41% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Future-Outlier Future-Outlier self-assigned this Oct 28, 2024
Copy link
Contributor

@davidmirror-ops davidmirror-ops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@davidmirror-ops davidmirror-ops merged commit d8afbcc into flyteorg:master Nov 5, 2024
51 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants