Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move default execution name generation to flyteadmin #5714

Merged

Conversation

wayner0628
Copy link
Contributor

@wayner0628 wayner0628 commented Aug 31, 2024

Tracking issue

  • This PR follows up on PR #5637 and migrates the default name generation functionality from flytectl to flyteadmin

Why are the changes needed?

What changes were proposed in this pull request?

  • Remove default name generation in flytectl

How was this patch tested?

Setup process

Screenshots

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

#5637

Docs link

Copy link

codecov bot commented Aug 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 36.17%. Comparing base (7a91799) to head (6930acc).
Report is 153 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5714   +/-   ##
=======================================
  Coverage   36.17%   36.17%           
=======================================
  Files        1303     1303           
  Lines      109663   109661    -2     
=======================================
+ Hits        39667    39668    +1     
+ Misses      65851    65848    -3     
  Partials     4145     4145           
Flag Coverage Δ
unittests-datacatalog 51.37% <ø> (ø)
unittests-flyteadmin 55.28% <ø> (ø)
unittests-flytecopilot 12.17% <ø> (ø)
unittests-flytectl 62.21% <ø> (+0.03%) ⬆️
unittests-flyteidl 7.12% <ø> (ø)
unittests-flyteplugins 53.34% <ø> (ø)
unittests-flytepropeller 41.76% <ø> (ø)
unittests-flytestdlib 55.35% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wayner0628 wayner0628 changed the title generate name at flyteadmin Move default execution name generation to flyteadmin Aug 31, 2024
Signed-off-by: wayner0628 <[email protected]>
@wayner0628 wayner0628 marked this pull request as ready for review September 1, 2024 02:37
@pingsutw pingsutw merged commit 96c799c into flyteorg:master Sep 2, 2024
53 checks passed
@wayner0628 wayner0628 deleted the update-flytectl-for-execution-name branch September 2, 2024 08:21
pmahindrakar-oss pushed a commit that referenced this pull request Sep 9, 2024
pmahindrakar-oss pushed a commit that referenced this pull request Sep 9, 2024
bgedik pushed a commit to bgedik/flyte that referenced this pull request Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants