Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backoff on etcd errors #5710

Merged
merged 1 commit into from
Sep 23, 2024
Merged

Backoff on etcd errors #5710

merged 1 commit into from
Sep 23, 2024

Conversation

EngHabu
Copy link
Contributor

@EngHabu EngHabu commented Aug 30, 2024

Tracking issue

fixes #5770

Why are the changes needed?

Propeller should backoff to avoid thrashing struggling etcserver even further.

What changes were proposed in this pull request?

Account for etcdserver errors when checking whether we should backoff or not.

How was this patch tested?

Setup process

Screenshots

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Signed-off-by: Haytham Abuelfutuh <[email protected]>
Copy link

codecov bot commented Aug 30, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 36.17%. Comparing base (7a91799) to head (d0e327d).
Report is 185 commits behind head on master.

Files with missing lines Patch % Lines
...eller/pkg/controller/nodes/task/backoff/handler.go 33.33% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5710   +/-   ##
=======================================
  Coverage   36.17%   36.17%           
=======================================
  Files        1303     1303           
  Lines      109663   109665    +2     
=======================================
+ Hits        39667    39670    +3     
+ Misses      65851    65850    -1     
  Partials     4145     4145           
Flag Coverage Δ
unittests-datacatalog 51.37% <ø> (ø)
unittests-flyteadmin 55.28% <ø> (ø)
unittests-flytecopilot 12.17% <ø> (ø)
unittests-flytectl 62.22% <ø> (+0.04%) ⬆️
unittests-flyteidl 7.12% <ø> (ø)
unittests-flyteplugins 53.34% <ø> (ø)
unittests-flytepropeller 41.76% <33.33%> (-0.01%) ⬇️
unittests-flytestdlib 55.35% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@EngHabu EngHabu marked this pull request as ready for review September 23, 2024 17:59
@EngHabu EngHabu requested a review from hamersaw September 23, 2024 18:00
@EngHabu EngHabu merged commit 0c3782b into master Sep 23, 2024
49 of 50 checks passed
@EngHabu EngHabu deleted the etcd-leader-changed-backoff branch September 23, 2024 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] etcdserver errors should cause Propeller to backoff
2 participants