Make BaseURL insensitive to trailing slashes for metadata endpoint redirect. #5458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for opening this pull request! 🙌 These tips will help get your PR across the finish line:
|
…direct. Signed-off-by: Yakov Dlougach <[email protected]>
Dlougach
force-pushed
the
yakov.dlougach/5456
branch
from
89f7820 to
8024b27
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5458 +/- ##
==========================================
- Coverage 61.07% 60.98% -0.10%
==========================================
Files 793 793
Lines 51226 51313 +87
==========================================
+ Hits 31288 31294 +6
- Misses 17062 17134 +72
- Partials 2876 2885 +9
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Yakov Dlougach <[email protected]>
eapolinario
approved these changes
Jun 11, 2024
|
Thank you! |
|
Congrats on merging your first pull request! 🎉 |
robert-ulbrich-mercedes-benz
pushed a commit
to robert-ulbrich-mercedes-benz/flyte
that referenced
this pull request
Jul 2, 2024
…direct. (flyteorg#5458) * Make BaseURL insensitive to trailing slashes for metadata endpoint redirect. Signed-off-by: Yakov Dlougach <[email protected]> * Lint renaming Signed-off-by: Yakov Dlougach <[email protected]> --------- Signed-off-by: Yakov Dlougach <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking issue
Example: Closes #5456
Why are the changes needed?
Fixes resolution of OpenID metadata URL redirect.
Without the change tests would fail:
What changes were proposed in this pull request?
Append a trailing slash to
BaseURLbefore runningResolveReferenceHow was this patch tested?
Unit tests only.
Setup process
Screenshots
Check all the applicable boxes
Related PRs
Docs link