add unsupported version tests

Signed-off-by: pmahindrakar-oss <[email protected]>
flyteorg · Sep 18, 2024 · fceba3c · fceba3c
1 parent 65552a3
commit fceba3c
Showing 1 changed file with 16 additions and 0 deletions.
diff --git a/flytepropeller/pkg/controller/config/config_test.go b/flytepropeller/pkg/controller/config/config_test.go
@@ -68,4 +68,20 @@ func TestIsSupportedSDKVersion(t *testing.T) {
 		}
 		assert.True(t, config.IsSupportedSDKVersion("flytekit", "v1.13.6b0"))
 	})
+	t.Run("unsupported dev version", func(t *testing.T) {
+		config := LiteralOffloadingConfig{
+			SupportedSDKVersions: map[string]string{
+				"flytekit": "1.13.4",
+			},
+		}
+		assert.False(t, config.IsSupportedSDKVersion("flytekit", "1.13.3.dev12+g990b450ea.d20240917"))
+	})
+	t.Run("unsupported beta version", func(t *testing.T) {
+		config := LiteralOffloadingConfig{
+			SupportedSDKVersions: map[string]string{
+				"flytekit": "1.13.4",
+			},
+		}
+		assert.False(t, config.IsSupportedSDKVersion("flytekit", "v1.13.3b0"))
+	})
 }