fix race condition

Signed-off-by: Alex Wu <[email protected]>
flyteorg · Feb 4, 2025 · e3f200b · e3f200b
1 parent b12cfdc
commit e3f200b
Showing 1 changed file with 16 additions and 6 deletions.
diff --git a/flyteadmin/pkg/manager/impl/execution_manager_test.go b/flyteadmin/pkg/manager/impl/execution_manager_test.go
@@ -2410,18 +2410,28 @@ func TestCreateWorkflowEvent_CurrentlyAborting(t *testing.T) {
 	assert.NotNil(t, resp)
 	assert.NoError(t, err)
 
-	mockDbEventWriter.On("Write", req)
-	req.Event.Phase = core.WorkflowExecution_QUEUED
+	req = &admin.WorkflowExecutionEventRequest{
+		RequestId: "1",
+		Event: &event.WorkflowExecutionEvent{
+			ExecutionId: &executionIdentifier,
+			Phase:       core.WorkflowExecution_QUEUED,
+			OccurredAt:  timestamppb.New(time.Now()),
+		},
+	}
 	resp, err = execManager.CreateWorkflowEvent(context.Background(), req)
 	assert.Nil(t, resp)
 	assert.NotNil(t, err)
 	adminError := err.(flyteAdminErrors.FlyteAdminError)
 	assert.Equal(t, adminError.Code(), codes.FailedPrecondition)
 
-	mockDbEventWriter = &eventWriterMocks.WorkflowExecutionEventWriter{}
-	mockDbEventWriter.On("Write", req)
-	execManager = NewExecutionManager(repository, r, getMockExecutionsConfigProvider(), getMockStorageForExecTest(context.Background()), mockScope.NewTestScope(), mockScope.NewTestScope(), &mockPublisher, mockExecutionRemoteURL, nil, nil, &mockPublisher, &mockPublisher, mockDbEventWriter)
-	req.Event.Phase = core.WorkflowExecution_RUNNING
+	req = &admin.WorkflowExecutionEventRequest{
+		RequestId: "1",
+		Event: &event.WorkflowExecutionEvent{
+			ExecutionId: &executionIdentifier,
+			Phase:       core.WorkflowExecution_RUNNING,
+			OccurredAt:  timestamppb.New(time.Now()),
+		},
+	}
 	resp, err = execManager.CreateWorkflowEvent(context.Background(), req)
 	assert.Nil(t, resp)
 	assert.NotNil(t, err)