Fix other tests

Signed-off-by: Eduardo Apolinario <[email protected]>
flyteorg · May 3, 2024 · c061933 · c061933
1 parent 75b9a33
commit c061933
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 0 deletions.
diff --git a/flytectl/cmd/demo/exec_test.go b/flytectl/cmd/demo/exec_test.go
@@ -53,6 +53,8 @@ func TestSandboxClusterExecWithoutCmd(t *testing.T) {
 	mockDocker := &mocks.Docker{}
 	reader := bufio.NewReader(strings.NewReader("test"))
 	s := testutils.Setup()
+	defer s.RestoreStandardFileDescriptors()
+
 	ctx := s.Ctx
 
 	mockDocker.OnContainerList(ctx, types.ContainerListOptions{All: true}).Return([]types.Container{

diff --git a/flytectl/cmd/demo/status_test.go b/flytectl/cmd/demo/status_test.go
@@ -15,13 +15,15 @@ func TestDemoStatus(t *testing.T) {
 	t.Run("Demo status with zero result", func(t *testing.T) {
 		mockDocker := &mocks.Docker{}
 		s := testutils.Setup()
+		defer s.RestoreStandardFileDescriptors()
 		mockDocker.OnContainerList(s.Ctx, types.ContainerListOptions{All: true}).Return([]types.Container{}, nil)
 		docker.Client = mockDocker
 		err := demoClusterStatus(s.Ctx, []string{}, s.CmdCtx)
 		assert.Nil(t, err)
 	})
 	t.Run("Demo status with running", func(t *testing.T) {
 		s := testutils.Setup()
+		defer s.RestoreStandardFileDescriptors()
 		ctx := s.Ctx
 		mockDocker := &mocks.Docker{}
 		mockDocker.OnContainerList(ctx, types.ContainerListOptions{All: true}).Return([]types.Container{

diff --git a/flytectl/cmd/demo/teardown_test.go b/flytectl/cmd/demo/teardown_test.go
@@ -80,6 +80,8 @@ func TestTearDownClusterFunc(t *testing.T) {
 	_ = util.SetupFlyteDir()
 	_ = util.WriteIntoFile([]byte("data"), configutil.FlytectlConfig)
 	s := testutils.Setup()
+	defer s.RestoreStandardFileDescriptors()
+
 	ctx := s.Ctx
 	mockDocker := &mocks.Docker{}
 	mockDocker.OnContainerList(ctx, types.ContainerListOptions{All: true}).Return(containers, nil)

diff --git a/flytectl/pkg/sandbox/status_test.go b/flytectl/pkg/sandbox/status_test.go
@@ -15,12 +15,14 @@ func TestSandboxStatus(t *testing.T) {
 	t.Run("Sandbox status with zero result", func(t *testing.T) {
 		mockDocker := &mocks.Docker{}
 		s := testutils.Setup()
+		defer s.RestoreStandardFileDescriptors()
 		mockDocker.OnContainerList(s.Ctx, types.ContainerListOptions{All: true}).Return([]types.Container{}, nil)
 		err := PrintStatus(s.Ctx, mockDocker)
 		assert.Nil(t, err)
 	})
 	t.Run("Sandbox status with running sandbox", func(t *testing.T) {
 		s := testutils.Setup()
+		defer s.RestoreStandardFileDescriptors()
 		ctx := s.Ctx
 		mockDocker := &mocks.Docker{}
 		mockDocker.OnContainerList(ctx, types.ContainerListOptions{All: true}).Return([]types.Container{