Skip to content

Commit

Permalink
Minor cleanup for Web API plugins (#5472)
Browse files Browse the repository at this point in the history
Signed-off-by: Jason Parraga <[email protected]>
  • Loading branch information
Sovietaced authored Jun 12, 2024
1 parent 3f4c2c8 commit 9484e36
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -54,9 +54,6 @@ type State struct {
// level retries, just errors from hitting API, inside the sync loop
SyncFailureCount int `json:"syncFailureCount,omitempty"`

// In creating the resource, this is the number of failures
CreationFailureCount int `json:"creationFailureCount,omitempty"`

// The time the execution first requests for an allocation token
AllocationTokenRequestStartTime time.Time `json:"allocationTokenRequestStartTime,omitempty"`

Expand Down
2 changes: 1 addition & 1 deletion flyteplugins/go/tasks/pluginmachinery/webapi/plugin.go
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ import (
// that the plugin loader will be called before any Handle/Abort/Finalize functions are invoked
type PluginLoader func(ctx context.Context, iCtx PluginSetupContext) (AsyncPlugin, error)

// PluginEntry is a structure that is used to indicate to the system a K8s plugin
// PluginEntry is a structure that is used to indicate to the system a WebAPI plugin
type PluginEntry struct {
// ID/Name of the plugin. This will be used to identify this plugin and has to be unique in the entire system
// All functions like enabling and disabling a plugin use this ID
Expand Down

0 comments on commit 9484e36

Please sign in to comment.