forked from NixOS/nixpkgs
-
Notifications
You must be signed in to change notification settings - Fork 6
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
percona: fix references to utilities in scripts
I encountered errors when attempting to run Vitess which calls out to mysqld_safe[1]. Several utilities are needed in order for it to run e.g. grep, sed, env, ps, date, hostname, etc. Additionally, if ps, kill, and grep aren't available to scripts/CMakeLists.txt, mysqld_start can end up getting generated with syntax errors as FIND_PROC will be substituted into the script template as an empty string[2][3]. The presence of systemd in percona-server_innovation seems to prevent mysqld_multi from being built on Linux so it gets patched conditionally. This same patch could be applied to MySQL if desired. [1]: https://github.com/vitessio/vitess/blob/v20.0.1/go/vt/mysqlctl/mysqld.go#L363-L369 [2]: https://github.com/percona/percona-server/blob/79c1086e8272ea96f162b25121b58e1b01ff853b/scripts/CMakeLists.txt#L255 [3]: https://github.com/percona/percona-server/blob/79c1086e8272ea96f162b25121b58e1b01ff853b/scripts/mysqld_safe.sh#L869
- Loading branch information
1 parent
d42f9eb
commit a5dcd41
Showing
2 changed files
with
27 additions
and
6 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters