Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cloud-init compatibility for Ubuntu VMs #20

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

leona-ya
Copy link
Member

@leona-ya leona-ya commented Jan 24, 2025

  • Add cloud-init disk with config files
  • update root ssh keys via qemu agent in ensure for ubuntu VMs

PL-133325 and PL-133372

Release process

  • Created changelog entry using ./changelog.sh

PR release workflow (internal)

  • PR has internal ticket
  • internal issue ID (PL-…) part of branch name
  • internal issue ID mentioned in PR description text
  • ticket is on Platform agile board
  • ticket state set to Pull request ready
  • if ticket is more urgent than within the next few days, directly contact a member of the Platform team

Design notes

  • Provide a feature toggle if the change might need to be adjusted/reverted quickly depending on context. Consider whether the default should be on or off. Example: rate limiting.
  • All customer-facing features and (NixOS) options need to be discoverable from documentation. Add or update relevant documentation such that hosted and guided customers can understand it as well. (will be done later, is noted)

Security implications

  • automated testing (tbd), manual testing, and code review

@leona-ya leona-ya changed the title Add cloud-init for ubuntu compatability Add cloud-init for ubuntu compatibility Jan 24, 2025
@leona-ya leona-ya force-pushed the PL-133325-ubuntu-vms branch 2 times, most recently from 5fe8bfc to 8cf897e Compare January 24, 2025 08:05
@leona-ya leona-ya changed the title Add cloud-init for ubuntu compatibility Add cloud-init compatibility for Ubuntu VMs Jan 24, 2025
@leona-ya leona-ya force-pushed the PL-133325-ubuntu-vms branch from 8cf897e to fb89a76 Compare January 24, 2025 09:23
Copy link
Member

@ctheune ctheune left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, i'll take over for test coverage and fixing the nixos integration tests.

src/fc/qemu/agent.py Outdated Show resolved Hide resolved
src/fc/qemu/agent.py Outdated Show resolved Hide resolved
src/fc/qemu/agent.py Outdated Show resolved Hide resolved
src/fc/qemu/hazmat/ceph.py Outdated Show resolved Hide resolved
src/fc/qemu/hazmat/ceph.py Outdated Show resolved Hide resolved
* Add cloud-init disk with config files
* update root ssh keys via qemu agent in ensure for ubuntu VMs

PL-133325
@leona-ya leona-ya force-pushed the PL-133325-ubuntu-vms branch from fb89a76 to 3ff4c6f Compare January 24, 2025 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants