resolving of ui bundle missed path by 1 level #120 #124
Conversation
|
Someone is attempting to deploy a commit to the Flyde Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
There was a problem hiding this comment.
@akim-muto great job!
One problem though - I just checked it on a test project, and because it has a local copy of the stdlib (because it installed
@flyde/runtime) it didn't work - the refactor of stdlib you've done did not reach it. A bit context here - The extension will always use a local copy of the stdlib if you've installed it, and only if it can resolve a @flyde/stdlib package in the working dir, it will use its own copy. After your change, everyone who installed @flyde/runtime will be stuck until they upgrade it, which is hard to enforce.
This means this is a breaking change - meaning there is no way around having temporary backwards compact support - in case the path doesn't exist, we can check the old path - without ".." - and leave a comment explaining why and suggest it can be removed in the future
|
Response to review. |
| @@ -21,11 +21,20 @@ export function macroNodeToDefinition<T>( | |||
| editorComponentBundleContent: "", | |||
| } as MacroEditorConfigCustomDefinition, | |||
| }; | |||
| const editorComponentPath = join( | |||
| importPath, | |||
| const BundlePathPlusOne = join( | |||
There was a problem hiding this comment.
this is redundant, you can inline it in line 30
as in just:
let editorComponentPath = join(
importPath,
'..',
macro.editorConfig.editorComponentBundlePath
);
|
@akim-muto reviewed again, this should work - left some improvement comments for the code itself |
|
Oh, you meant to leave it in the code comments. I'm going! |
|
@akim-muto great job, tested and backwards compat. is working great 👍 |
New breaking change here
Who does this affect:
Their are using Macro Editor.
How to migrate:
Change way to specify path to Macro Editor bundle path.
Directory one up.
ditorComponentBundlePath: "../../../macro.tsx" → ditorComponentBundlePath: "../../macro.tsx"
Why make this breaking change:
We changed it to the one that most people expect as a behavior.
Severity (number of people affected x effort):
Undocumented and few users are expected.
The response is simply to replace the letters.
Therefore, the impact is low.