adds ability to select and remove connections, fixes #107 #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Tokyros is attempting to deploy a commit to the Flyde Team on Vercel. A member of the Team first needs to authorize it. |
GabiGrin
reviewed
Apr 13, 2024
GabiGrin
reviewed
Apr 13, 2024
flow-editor/src/visual-node-editor/SelectionIndicator/SelectionIndicator.tsx
Show resolved
Hide resolved
GabiGrin
reviewed
Apr 13, 2024
Comment on lines
792
to
794
| !ids.includes(getConnectionId({from, to})) && | ||
| ids.indexOf(from.insId) === -1 && | ||
| ids.indexOf(to.insId) === -1 |
There was a problem hiding this comment.
my bad, but.. boy scout rule
Suggested change
| !ids.includes(getConnectionId({from, to})) && | |
| ids.indexOf(from.insId) === -1 && | |
| ids.indexOf(to.insId) === -1 | |
| !ids.includes(from.insId) && | |
| !ids.includes(to.insId) |
GabiGrin
reviewed
Apr 13, 2024
| @@ -162,6 +164,7 @@ export type ClipboardData = { | |||
| export type GroupEditorBoardData = { | |||
| viewPort: ViewPort; | |||
| selected: string[]; | |||
There was a problem hiding this comment.
now that we have selected connections "selected" becomes (even more) vague
Suggested change
| selected: string[]; | |
| selectedInstances: string[]; |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
GabiGrin
changed the title
|
@Tokyros awesome work! |
GabiGrin
reviewed
Apr 13, 2024
core/src/connect/helpers.ts
Outdated
| @@ -131,6 +131,14 @@ export function connectionData(fromRaw: any, toRaw: any, delayed?: any): any { | |||
| }; | |||
| } | |||
|
|
|||
| export const getConnectionId = (connectionData: ConnectionData) => { | |||
There was a problem hiding this comment.
wondering if core is the place for this util - can't see a core usage for it
light mode (can be viewed by setting VSCode to a light theme and reloading) looks bad
|
GabiGrin
force-pushed
the
connections-selection
branch
from
9941b02 to
046c933
Compare
|
Thanks @Tokyros, awesome work 🕺 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issue link - #107
This PR implements the ability to select connection via mouse click.
Once selected connections can be delete via backspace key or by clicking the "Delete" button on the Selection Indicator action bar at the bottom.
Users cannot select connections and Node instances at the same time, so selecting either will clear the selection of the other.
Implementation details
<path>element with the same shape and a larger stroke then the connection one, all mouse events are registered to this invisible path.Once the mouse is in the range of selection the connection will be highlighted and dashed.
selectedConnectionsstate to differentiate it from the node instances selection.pointer-events: nonewhich was preventing any pointer actions on the connections svg, had to also ammend the selection box logic because it broke after removing it.