-
Notifications
You must be signed in to change notification settings - Fork 340
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Controller sharding and horizontal scaling #1444
Conversation
f2d26e9
to
bb3c6ba
Compare
Signed-off-by: Stefan Prodan <[email protected]>
bb3c6ba
to
e1e39e3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great guide! I added some suggestions, mainly around a more active/call-to-action tone.
@@ -2,7 +2,7 @@ | |||
title: "Bootstrap cheatsheet" | |||
linkTitle: "Bootstrap" | |||
description: "Showcase various configurations of Flux controllers at bootstrap time." | |||
weight: 30 | |||
weight: 29 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want to rather sort the pages in here alphabetically so users can skip through them visually more easily?
touch clusters/my-cluster/flux-system/shard1/kustomization.yaml | ||
``` | ||
|
||
### Configure controller sharding |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel all these steps should rather be a numbered list. Alternatively enumerate the headings like ### 2. Configure controller sharding
patch: | | ||
- op: add | ||
path: /spec/template/spec/containers/0/args/0 | ||
value: --watch-label-selector=sharding.fluxcd.io/key notin (shard1, shard2) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For some reason there's trailing spaces at the end of this line in the rendered output.
Co-authored-by: Max Jonas Werner <[email protected]> Signed-off-by: Stefan Prodan <[email protected]>
Co-authored-by: Sunny <[email protected]> Signed-off-by: Stefan Prodan <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Add controller sharding cheatsheet.
Preview: https://deploy-preview-1444--fluxcd.netlify.app/flux/cheatsheets/sharding/