Fix signing commits with GPG key #572
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knutgoetz
force-pushed
the
fix/expect-gpg-key-ring-as-path
branch
from
bf41052 to
59f84ec
Compare
Signed-off-by: Knut Götz <[email protected]>
knutgoetz
force-pushed
the
fix/expect-gpg-key-ring-as-path
branch
from
59f84ec to
9cac86c
Compare
darkowlzz
reviewed
Nov 8, 2023
knutgoetz
force-pushed
the
fix/expect-gpg-key-ring-as-path
branch
from
9cac86c to
1316b50
Compare
This aligns the behavior of the provider with the `gpg_key_id` parameter of the FluxCD CLI. Not sure if the GPG was even possible since the code expected the contents of the keyring to be passed as a string. Signed-off-by: Knut Götz <[email protected]>
knutgoetz
force-pushed
the
fix/expect-gpg-key-ring-as-path
branch
from
1316b50 to
18b6ef7
Compare
|
@darkowlzz thx for the review. I adjusted the docs. |
This was referenced Nov 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this is merged the provider code expects the content of the exported GPG keyring to be set as the value of the
gpg_key_ringattribute. I could not make this work and i doubt that it is possible since the keyring content is expected in a binary format (and not as an armored string) and thus cannot be passed as a terraformTypeString.Also this behaviour of the provider does not align with the behaviour of
flux bootstrapwhich also expects a path.This PR will align the behaviour of the
flux_bootstrap_gitresource with the behaviour offlux bootstrap.Addresses #571