-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Kustomize components #412
Conversation
Hey @klausenbusk can you please add here the tests you wrote. |
I have added the test back. I'm not sure if we want to use |
We can't use the API types in pkg, that would get us to cyclic dependency between the controller and pkg which would break go.mod. |
I'm not sure the fuzz failure is related to this change:
|
@klausenbusk we can ignore the fuzzers, these were broken upstream and we're going to fix them in a different PR. |
I have run the tests in flux2 with this PR, and it passes successfully. |
Fuzzing has been fixed in main, please rebase. |
Any idea why the test is failing on macos-12 https://github.com/fluxcd/pkg/actions/runs/3539040439/jobs/5940762510? |
@klausenbusk use: func testTempDir(t *testing.T) (string, error) {
tmpDir := t.TempDir()
tmpDir, err := filepath.EvalSymlinks(tmpDir)
if err != nil {
return "", fmt.Errorf("error evaluating symlink: '%w'", err)
}
return tmpDir, err
} instead of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks @klausenbusk for the PR 🙇♂️
Do you need more from me, before this can be merged? :) |
@klausenbusk please rebase so we can go ahead with the merge. |
Ref: fluxcd/kustomize-controller#753 Signed-off-by: Kristian Klausen <[email protected]>
Rebased :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks @klausenbusk! 🙇
Ref: fluxcd/kustomize-controller#753
Signed-off-by: Kristian Klausen [email protected]