Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: use stringData for secret of GitHub PAT #873

Merged
merged 1 commit into from
Jul 9, 2024
Merged

docs: use stringData for secret of GitHub PAT #873

merged 1 commit into from
Jul 9, 2024

Conversation

ThomasDangleterre
Copy link
Contributor

…ider doc

@stefanprodan stefanprodan changed the title chore: set stringData for secret of github PAT in githubdispatch prov… docs: use stringData for secret of GitHub PAT Jul 9, 2024
@stefanprodan stefanprodan added the area/docs Documentation related issues and pull requests label Jul 9, 2024
stefanprodan
stefanprodan approved these changes Jul 9, 2024
View reviewed changes
Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @ThomasDangleterre

@stefanprodan stefanprodan added the backport:release/v1.3.x To be backported to release/v1.3.x label Jul 9, 2024
matheuscscp
matheuscscp approved these changes Jul 9, 2024
View reviewed changes
Copy link
Member

@matheuscscp matheuscscp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@stefanprodan stefanprodan merged commit 86f2a6d into fluxcd:main Jul 9, 2024
8 checks passed
@fluxcdbot fluxcdbot mentioned this pull request Jul 9, 2024
Merged
@fluxcdbot
Copy link
Member

Successfully created backport PR for release/v1.3.x:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matheuscscp matheuscscp matheuscscp approved these changes

@stefanprodan stefanprodan stefanprodan approved these changes

Assignees
No one assigned
Labels
area/docs Documentation related issues and pull requests backport:release/v1.3.x To be backported to release/v1.3.x
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ThomasDangleterre @fluxcdbot @matheuscscp @stefanprodan