Add LabelSelectors for Event Sources #325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefanprodan
reviewed
Feb 9, 2022
controllers/event_handling_test.go
Outdated
| forwarded: true, | ||
| }, | ||
| { | ||
| name: "forwards events the label matches", |
There was a problem hiding this comment.
Can you please add a test for "drop events when labels don't match"
stefanprodan
added
area/alerting
internal/server/event_handlers.go
Outdated
| @@ -96,12 +99,40 @@ func (s *EventServer) handleEvent() func(w http.ResponseWriter, r *http.Request) | |||
| source.Namespace = alert.Namespace | |||
| } | |||
|
|
|||
| if (source.Name == "*" || event.InvolvedObject.Name == source.Name) && | |||
| event.InvolvedObject.Namespace == source.Namespace && | |||
| if event.InvolvedObject.Namespace == source.Namespace && | |||
There was a problem hiding this comment.
Let's extract this logic to a function called eventMatchesAlert
Signed-off-by: Somtochi Onyekwere <[email protected]>
somtochiama
force-pushed
the
label-selector
branch
from
ace61d8 to
519b6a5
Compare
stefanprodan
approved these changes
Feb 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: #275
Signed-off-by: Somtochi Onyekwere [email protected]