Add timestamp as label for alertmanager #298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without the timestamp there is not enough entropy in the hash for alertmanager to recongise that this is a new alert for some cases. Adding the timestamp ensures that a new hash for the alert is created each time and therefore no updates get missed. Signed-off-by: Alan Hollis <[email protected]>
Alan01252
force-pushed
the
feature/alertmanager
branch
from
0c1e0cb to
5a21f69
Compare
|
This allows the alertmanager administrator to determine how to group alerts. As an example if you choose not to group by timestamp you can send alerts to slack which look like.
However if you want to then group by timestamp and get all the alerts
|
stefanprodan
approved these changes
Jan 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without the timestamp there is not enough entropy in the hash for
alertmanager to recongise that this is a new alert for some cases.
Adding the timestamp ensures that a new hash for the alert is created
each time and therefore no updates get missed.