Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

providers/sentry: add environment support #223

Merged
merged 3 commits into from
Jul 26, 2021
Merged

providers/sentry: add environment support #223

merged 3 commits into from
Jul 26, 2021

Conversation

BeryJu
Copy link
Contributor

@BeryJu BeryJu commented Jul 26, 2021

use channel configuration for sentry environment to re-use the same DSN for multiple clusters

created this as a separate PR to not clash with the other sentry PR

use channel configuration for sentry environment to re-use the same DSN for multiple clusters

Signed-off-by: Jens Langhammer <[email protected]>
@BeryJu
Copy link
Contributor Author

BeryJu commented Jul 26, 2021

sorry for the flood of PRs, I have one other PR prepared after this one is merged

@stefanprodan
Copy link
Member

Can you please add a note in here to how Channel is used for sentry? Without docs no one would guess this.

@BeryJu
Copy link
Contributor Author

BeryJu commented Jul 26, 2021

Of course, you reckon I should just create a new category somewhere along line 217?

Signed-off-by: Jens Langhammer <[email protected]>
Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @BeryJu

@stefanprodan stefanprodan added area/alerting Alerting related issues and PRs enhancement New feature or request labels Jul 26, 2021
@stefanprodan stefanprodan merged commit 952d4f4 into fluxcd:main Jul 26, 2021
@BeryJu BeryJu deleted the sentry-environment branch July 26, 2021 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/alerting Alerting related issues and PRs enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants