Add self signed cert to provider #184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phillebaba
force-pushed
the
feature/self-signed-certs
branch
from
747dbba to
70c8cdd
Compare
Signed-off-by: Philip Laine <[email protected]>
phillebaba
force-pushed
the
feature/self-signed-certs
branch
from
70c8cdd to
8f3b685
Compare
Signed-off-by: Philip Laine <[email protected]>
Signed-off-by: Philip Laine <[email protected]>
Signed-off-by: Philip Laine <[email protected]>
stefanprodan
approved these changes
Apr 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #183
Adds and optional cert secret to the provider which will be added to the different notifiers http clients. This implementation skips the following notifiers as they are not possible to self host.