Refactor: Adopt Flux runtime conditions and status standards #745
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Kustomization.status
conform to the Kubernetes kstatus standardKustomization.status.conditions
conform to the Kubernetes standard conditionsfluxcd/pkg/runtime/conditions
andfluxcd/pkg/runtime/controller
for status operationsTest image:
ghcr.io/fluxcd/kustomize-controller:rc-747a2c9e
Reconciling
status conditionThis PR introduces a new status condition named
Reconciling
which improves the observability for the actions performed by the controller during a reconciliation run.The
Reconciling
message reflects the current action being executed e.g.:X
with a timeout ofY
X
with a timeout ofY
X
with a timeout ofY
X
with a timeout ofY
The
Reconciling
condition is added to the status once the reconciliation starts and itsMessage
is updated before each action performed by the controller during a reconciliation run.If the reconciliation encountered an error, the
Ready
condition is set toFalse
andReconciling
is left in place, to signal that the controller will retry the failed action.If the reconciliation finishes with no errors, The
Reconciling
condition is removed from status and theReady
condition is set toTrue
.Closes: #663
Ref: fluxcd/pkg#380