Sort SOPS masterkeys so offline decrypt methods are tried first #726
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Boris Kreitchman <[email protected]>
|
I think it'd be better to get this merged to upstream SOPS rather than here, we have been trying to get rid of all our custom SOPS code by contributing it back upstream. cc: @hiddeco |
bkreitch
changed the title
|
I'm for merging this, it could take months before the next SOPS release. |
stefanprodan
added
enhancement
hiddeco
approved these changes
Sep 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to sort master keys so PGP/age keys appear before the others and being used first. Thus if one of local methods is successful we avoid going to remote KMS/HCVault which may not be accessible from specific network and cause unnecessary timeouts or have some other cost.
Originally I've submitted PR to SOPS project as solution for this issue, but as it seems it could be a while till that PR is reviewed and new version is released. And since kustomize-controller has some internal SOPS implementation same thing could be achieved before passing data to SOPS.