Add a common finalizer for the reconcilers #433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Other controllers use a common constant for finalizers. In this repository, we have two separate constants with the same common value for the finalizer. Replace the two finalizer constants with a common finalizer for the controller. Signed-off-by: Sunny <[email protected]>
darkowlzz
force-pushed
the
common-finalizer
branch
from
6a9e7e4 to
5d39cea
Compare
hiddeco
approved these changes
Aug 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #430, the new metric helper constructor was provided with ImageRepository finalizer only as the finalizer values are the same for both the reconcilers. This change introduces a common finalizer constant to avoid using one specific kind of finalizer.
Other controllers use a common constant for finalizers. In this repository, we have two separate constants with the same common value for the finalizer. Replace the two finalizer constants with a common finalizer for the controller.
Deprecate the kind specific finalizers from v1beta2 API.