tests: Move common provider helpers to tftestenv #288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefanprodan
approved these changes
Jul 26, 2022
Move the common cloud provider utilities from tests/integration/ into tests/tftestenv/ so that they can be shared with other tests. Signed-off-by: Sunny <[email protected]>
Replace the common cloud provider helpers with the helpers in tftestenv. Signed-off-by: Sunny <[email protected]>
darkowlzz
force-pushed
the
tftestenv-provider-helpers
branch
from
68edaab to
c96012a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move the common provider helper code from
tests/integrationintotests/tftestenvindependent of the terraform state output variable names. This would help share
common test code between all the cloud provider tests in different repos.
After this, tftestenv can be easily moved to a separate repository and it can be
imported by different tests for infrastructure provisioning and interaction
with the cloud providers.