Set default observedGeneration to -1 #189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/assign makkes |
hiddeco
force-pushed
the
default-observed-generation
branch
from
614df3c to
637f83c
Compare
This ensures tools like `kstatus` do not consider the resource to be in a `Ready` state premataturely due to `generation` and `observedGeneration` equaling to `0` for a short period of time. Signed-off-by: Tom Huang <[email protected]>
hiddeco
force-pushed
the
default-observed-generation
branch
from
637f83c to
293bf80
Compare
hiddeco
approved these changes
Nov 22, 2021
This was referenced Dec 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This sets the status.observedGeneration field to -1 by default. This is to address issue outlined by fluxcd/flux2#2007.
Signed-off-by: Tom Huang [email protected]