Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

Add logging when set status phase with revision return err #536

Closed
wants to merge 1 commit into from
Closed

Add logging when set status phase with revision return err #536

wants to merge 1 commit into from

Conversation

andylibrian
Copy link

@andylibrian andylibrian commented Sep 23, 2020

This function works fine in normal cases. However, when a person
makes a mistake, for example installing different version of CRDs,
the err returned from SetStatusPhaseWithRevision would help tell
what's wrong.

Due to lack of this log, one might have no clue why a chart is
constantly deployed even when there is no change.

ref: #457

In my case, this log helps me to tell that I was on a wrong CRD version:

ts=2020-09-23T04:24:01.763104967Z caller=release.go:517 component=release release=datadog-agent-datadog-agent targetNamespace=datadog-agent resource=datadog-agent:helmrelease/datadog-agent helmVersion=v3 warning="HelmRelease.helm.fluxcd.io "datadog-agent" is invalid: status.conditions.type: Unsupported value: "Deployed": supported values: "ChartFetched", "Released", "RolledBack"" action=upgrade

Note:
There are a few other usages of SetStatusPhaseWithRevision in the same file.
Let me know if we should add logs to the other lines.

This function works fine in normal cases. However, when a person
makes a mistake, for example installing different version of CRDs,
the err returned from SetStatusPhaseWithRevision would help tell
what's wrong.

Due to lack of this log, one might have no clue why a chart is
constantly deployed even when there is no change.

ref: #457
@andylibrian andylibrian closed this Oct 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant