This repository has been archived by the owner on Nov 1, 2022. It is now read-only.
Add logging when set status phase with revision return err #536
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This function works fine in normal cases. However, when a person
makes a mistake, for example installing different version of CRDs,
the err returned from SetStatusPhaseWithRevision would help tell
what's wrong.
Due to lack of this log, one might have no clue why a chart is
constantly deployed even when there is no change.
ref: #457
In my case, this log helps me to tell that I was on a wrong CRD version:
Note:
There are a few other usages of
SetStatusPhaseWithRevision
in the same file.Let me know if we should add logs to the other lines.