[RFC-007] Flux cli support for GitHub app authentication #5103
Conversation
dipti-pai
force-pushed
the
github-app-auth
branch
from
29dbd77 to
f0fd577
Compare
dipti-pai
changed the title
|
This is on hold until we release source-controller v1.5.0 |
There was a problem hiding this comment.
@dipti-pai Please rebase 🙏
I tested this PR and was able to both create a github app secret in-cluster and with --export, and also create a GitRepository source with provider github 👍
Left a comment about the create secret githubapp command example.
dipti-pai
force-pushed
the
github-app-auth
branch
2 times, most recently
from
ec38a49 to
1776eed
Compare
|
@dipti-pai I'm so sorry I asked you to rebase the other day, we could have waited until source-controller was released 😅 source-controller 1.5.0 is now released and bumped in the dependencies already, so if you rebase one last time and remove the temporary dependency on your fork we can finally merge this PR 🙏 |
…the following changes - - Add flux create secret githubapp command that accepts and validates the inputs to create a github app secret with options to export the secret yaml or create the secret directly in the Kubernetes cluster - Add tests for flux create secret githubapp command - Add flux create source git command that accepts and validates the inputs to create a gitrepository source with for github provider with options to export the source yaml or create the github gitrepository source directly in the Kubernetes cluster. - Add tests for flux create source git command for github provider. Signed-off-by: Dipti Pai <[email protected]>
dipti-pai
force-pushed
the
github-app-auth
branch
from
1776eed to
c15eb30
Compare
No worries, rebased :) Thanks. |
Add
flux create secret githubappcommand that accepts and validates the inputs to create a github appsecretwith options to export the secret yaml or create the secret directly in the Kubernetes clusterAdd tests for
flux create secret githubappcommandUpdate
flux create source gitcommand to accepts and validategithubprovider with options to export the source yaml or create the githubGitRepositorysource directly in the Kubernetes cluster.Add tests for flux create source git command for
githubprovider.Closes #5097