Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated io/ioutil from flux tree #2113

Merged
merged 1 commit into from
Nov 22, 2021
Merged

Remove deprecated io/ioutil from flux tree #2113

merged 1 commit into from
Nov 22, 2021

Conversation

stefanprodan
Copy link
Member

Fix: #1658 this was the last place where ioutil was used in Flux v2 and the GitOps Toolkit controllers.

@stefanprodan stefanprodan added the area/ci CI related issues and pull requests label Nov 22, 2021
@stefanprodan stefanprodan requested a review from hiddeco November 22, 2021 15:55
@dholbach
Copy link
Member

There's 3 more small pieces of use of io/ioutil, see #1658 (comment) - not sure if you'd like to have separate issues for those?

@stefanprodan
Copy link
Member Author

@dholbach the website and the watcher example are not part of flux2 distribution. Going to fix now go-git-providers.

@hiddeco hiddeco merged commit aed7341 into main Nov 22, 2021
@hiddeco hiddeco deleted the remove-ioutil branch November 22, 2021 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hiddeco hiddeco hiddeco approved these changes

Assignees
No one assigned
Labels
area/ci CI related issues and pull requests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove deprecated io/ioutil from projects
3 participants
@stefanprodan @dholbach @hiddeco