This repository has been archived by the owner on Nov 1, 2022. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The kubectl version and helmrelease CRD from our test scaffold needed to be upgraded. I have not been able to run a full e2e test against the release candidate until now, only by hand smoke testing and with beta and alpha releases. These changes allow e2e itself to pass, given there is a satisfactory version of Kubernetes cluster prepared.
After the release of v1.22.0 final, Kind will be updated, and the review machinery for PRs can be updated to run against the new version as well.
In the mean time, I have prepared a v1.22.0-rc.0 cluster with Kubeadm release candidate and Weave Net, which shows the e2e passing locally, having added these changes to our most recent release. 👍