This repository has been archived by the owner on Nov 1, 2022. It is now read-only.
Store public key in k8s secret #3411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alaa
force-pushed
the
feat/store_pub_key_in_k8s_secret
branch
2 times, most recently
from
0b06322 to
c11e416
Compare
added 2 commits
February 26, 2021 07:22
go.mod - reset k8s machinery to 1.17.17 This is the latest release that we can update to -- see fluxcd#3378 Try to remove when distribution/distribution#2905 is out docker/distribution patch still needed for now (Put it back for now.) On 2021-02-25 this has been merged, 2.7.2 of docker/distribution should include it hopefully relatively soon! Signed-off-by: Kingdon Barrett <[email protected]>
|
Hi @kingdonb, just a friendly reminder. |
|
Thanks, this looks straightforward and I don't think it has any potential to cause harm or break things. I will see that it gets included in the reviews for 1.22.0, which should be coming out this week. 🙌 |
Signed-off-by: Matt Willsher <[email protected]> Signed-off-by: Kingdon Barrett <[email protected]>
Signed-off-by: Herman Banken <[email protected]> Signed-off-by: Kingdon Barrett <[email protected]>
Signed-off-by: Alaa Qutaish <[email protected]> Signed-off-by: Kingdon Barrett <[email protected]>
kingdonb
force-pushed
the
feat/store_pub_key_in_k8s_secret
branch
from
c11e416 to
cb61b26
Compare
|
I rebased this to include it in the omnibus branch that I've composed for Flux v1.22.0 release. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a clone of the old #2916 for the reason that the upstream fork of the #2916 was deleted therefore opening this new PR.
For more details about the purpose of this change, please check the conversation here: #2916