This repository has been archived by the owner on Nov 1, 2022. It is now read-only.
sets memcached namespace as required by flux deployment #3346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joaovitor
force-pushed
the
memcache_namespace
branch
from
c3e5b0c to
bc753c3
Compare
https://github.com/fluxcd/flux/blob/master/chart/flux/templates/deployment.yaml#L208 ``` - --memcached-hostname={{ .Values.memcached.hostnameOverride | default (printf "%s-memcached" (include "flux.fullname" .)) }} ``` Signed-off-by: Joao Vitor Lacerda Guimaraes <[email protected]>
squaremo
force-pushed
the
memcache_namespace
branch
from
bc753c3 to
5e92d88
Compare
squaremo
approved these changes
Nov 30, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sets memcached namespace as required by flux deployment
The deployment of helm chart requires the memcache service in the same namespace of flux deployment.
This small change sets the namespace in the service deployment.
https://github.com/fluxcd/flux/blob/master/chart/flux/templates/deployment.yaml#L208