This repository was archived by the owner on Nov 1, 2022. It is now read-only.
Add a secretDataKey parameter to the Flux Helm chart #3227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hiddeco
reviewed
Jul 31, 2020
|
/rebase |
Adding a secretDataKey parameter to the Flux Helm chart enables the user to override the default data key `identity` and thereby potentially create the secret from a file with a different name (such as id_rsa) or use a pre-existing secret that stores the key value using a different data key. Expanding the Helm chart's documentation on the subject of ssh keys to add some clarity and cover this parameter.
hiddeco
force-pushed
the
chart-add-secretdatakey
branch
from
e0a0feb to
903f358
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a secretDataKey parameter to the Flux Helm chart enables the user to override the default data key
identityand thereby potentially create the secret from a file with a different name (such as id_rsa) or use a pre-existing secret that stores the key value using a different data key.Expanding the Helm chart's documentation on the subject of ssh keys to add some clarity and cover this parameter.
resolves #3226