This repository has been archived by the owner on Nov 1, 2022. It is now read-only.
Unmarshal Docker image labels separately #2785
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2opremio
reviewed
Jan 25, 2020
hiddeco
force-pushed
the
bug/timestamp-label
branch
from
dd4b80c to
e1f3257
Compare
To prevent the created field from never getting set when a `LabelTimestampFormatError` is returned, which is used as a fallback in case the labels have an invalid (non RFC3339 date-time) format.
hiddeco
force-pushed
the
bug/timestamp-label
branch
from
e1f3257 to
d29c752
Compare
2opremio
approved these changes
Jan 27, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To prevent the created field from never getting set when
LabelTimestampFormatErroris returned, which is used as a fallback in case the labels have an invalid (non RFC3339 date-time) format.Fixes #2699