This repository has been archived by the owner on Nov 1, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
prevents AWS errors when not using AWS #1810
Closed
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -334,23 +334,37 @@ func main() { | |
|
||
// Wrap the procedure for collecting images to scan | ||
{ | ||
awsConf := registry.AWSRegistryConfig{ | ||
Regions: *registryAWSRegions, | ||
AccountIDs: *registryAWSAccountIDs, | ||
BlockIDs: *registryAWSBlockAccountIDs, | ||
awsOptions := []string{ | ||
"registry-ecr-region", | ||
"registry-ecr-include-id", | ||
"registry-ecr-exclude-id", | ||
} | ||
credsWithAWSAuth, err := registry.ImageCredsWithAWSAuth(imageCreds, log.With(logger, "component", "aws"), awsConf) | ||
if err != nil { | ||
logger.Log("warning", "AWS authorization not used; pre-flight check failed") | ||
} else { | ||
imageCreds = credsWithAWSAuth | ||
usingAWS := false | ||
for _, awsOption := range awsOptions { | ||
if fs.Changed(awsOption) { | ||
usingAWS = true | ||
break | ||
} | ||
} | ||
if *dockerConfig != "" { | ||
credsWithDefaults, err := registry.ImageCredsWithDefaults(imageCreds, *dockerConfig) | ||
if usingAWS { | ||
awsConf := registry.AWSRegistryConfig{ | ||
Regions: *registryAWSRegions, | ||
AccountIDs: *registryAWSAccountIDs, | ||
BlockIDs: *registryAWSBlockAccountIDs, | ||
} | ||
credsWithAWSAuth, err := registry.ImageCredsWithAWSAuth(imageCreds, log.With(logger, "component", "aws"), awsConf) | ||
if err != nil { | ||
logger.Log("warning", "--docker-config not used; pre-flight check failed", "err", err) | ||
logger.Log("warning", "AWS authorization not used; pre-flight check failed") | ||
} else { | ||
imageCreds = credsWithDefaults | ||
imageCreds = credsWithAWSAuth | ||
} | ||
if *dockerConfig != "" { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Using a docker config is an alternative to ECR auth so it should not depend on AWS being enabled or nor. |
||
credsWithDefaults, err := registry.ImageCredsWithDefaults(imageCreds, *dockerConfig) | ||
if err != nil { | ||
logger.Log("warning", "--docker-config not used; pre-flight check failed", "err", err) | ||
} else { | ||
imageCreds = credsWithDefaults | ||
} | ||
} | ||
} | ||
} | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This breaks Weave Cloud and any other user that relies on Flux to automatically setup ECR auth.