Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

Release Helm chart v0.6.1 #1713

Merged
merged 4 commits into from
Feb 7, 2019
Merged

Release Helm chart v0.6.1 #1713

merged 4 commits into from
Feb 7, 2019

Conversation

stefanprodan
Copy link
Member

No description provided.

@stephenmoloney
Copy link
Contributor

missing reference to improvement

# Do not scan images that match these glob expressions
excludeImage:

@stefanprodan
Copy link
Member Author

Thanks @stephenmoloney I've added it.

hiddeco
hiddeco approved these changes Feb 7, 2019
View reviewed changes
Copy link
Member

@hiddeco hiddeco left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK to me -- in previous releases we included the version bump as an improvement but as this PR itself bumps the version it may be a bit weird to reference to the release PR as an 'improvement'.

@stefanprodan
Copy link
Member Author

Yes I forgot about that, the change log should contain the version bump even if it's the same PR

@stefanprodan stefanprodan merged commit d48d244 into master Feb 7, 2019
@stefanprodan stefanprodan deleted the chart-v0.6.1 branch February 7, 2019 12:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hiddeco hiddeco hiddeco approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stefanprodan @stephenmoloney @hiddeco