add private registries integration docs #1237
Merged
+104
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ArieLevs Thanks for the contribution, would you mind adding a link to the page from the index.md file within docs/use-tf-controller/ directory, so that the page will become visible when the documentation is generated as well? |
|
@ilithanos done |
ilithanos
requested changes
Mar 11, 2024
There was a problem hiding this comment.
Thanks a lot for getting the link from index.md into the PR.
You've written a good piece of documentation and I really appreciate you taking the time to help out.
There's a few corrections needed to increase the readability of the documentation suggested in the review, when these sections are updated I can merge the PR 👍
docs/use-tf-controller/integration-with-terraform-private-registries.md
Outdated
Show resolved
Hide resolved
docs/use-tf-controller/integration-with-terraform-private-registries.md
Outdated
Show resolved
Hide resolved
docs/use-tf-controller/integration-with-terraform-private-registries.md
Outdated
Show resolved
Hide resolved
docs/use-tf-controller/integration-with-terraform-private-registries.md
Outdated
Show resolved
Hide resolved
docs/use-tf-controller/integration-with-terraform-private-registries.md
Outdated
Show resolved
Hide resolved
…stries.md Co-authored-by: Tonni Follmann <[email protected]>
…stries.md Co-authored-by: Tonni Follmann <[email protected]>
…stries.md Co-authored-by: Tonni Follmann <[email protected]>
…stries.md Co-authored-by: Tonni Follmann <[email protected]>
…stries.md Co-authored-by: Tonni Follmann <[email protected]>
|
I knew I should let chatGPT do the grammer 😅 done, committed via the PR |
ilithanos
approved these changes
Mar 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #1189