Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

testsuite: disable hwloc reader tests #926

Merged
merged 1 commit into from
Apr 6, 2022

Conversation

garlick
Copy link
Member

@garlick garlick commented Apr 3, 2022

Problem: resource.get-xml RPC is being deprecated in flux-core,
but the fluxion hwloc reader still depends on it.

Disable sharness tests that fail without this RPC as a stopgap
measure, so flux-core can proceed with removal.

Fixes #925

Problem: resource.get-xml RPC is being deprecated in flux-core,
but the fluxion hwloc reader still depends on it.

Disable sharness tests that fail without this RPC as a stopgap
measure, so flux-core can proceed with removal.

Fixes flux-framework#925
@codecov
Copy link

codecov bot commented Apr 3, 2022

Codecov Report

Merging #926 (48f1c9a) into master (d411832) will decrease coverage by 0.0%.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           master    #926     +/-   ##
========================================
- Coverage    74.0%   73.9%   -0.1%     
========================================
  Files          79      79             
  Lines        9127    9127             
========================================
- Hits         6755    6747      -8     
- Misses       2372    2380      +8     
Impacted Files Coverage Δ
resource/modules/resource_match.cpp 74.1% <0.0%> (-0.7%) ⬇️

@garlick
Copy link
Member Author

garlick commented Apr 4, 2022

We've decided to push flux-framework/flux-core#4263 off to next month's release but it would be good to get at least this stopgap PR into this month's fluxion release so that we won't have a lock-step upgrade requirement next month.

@dongahn
Copy link
Member

dongahn commented Apr 6, 2022

Sounds reasonable and I approve so feel free to put MWP.

So this RPC has been completely deprecated even for a singe user instance?

Could you open up a ticket about this, though? This is an import test case for real users behind it and we probably want to port this to rv1exec in a near future.

@garlick
Copy link
Member Author

garlick commented Apr 6, 2022

So this RPC has been completely deprecated even for a singe user instance?

Yes.

Could you open up a ticket about this, though? This is an import test case for real users behind it and we probably want to port this to rv1exec in a near future.

Sure, will do. I think these tests are repeated lower down against the rv1 reader but I could be mistaken.

@garlick garlick added the merge-when-passing mergify.io - merge PR automatically once CI passes label Apr 6, 2022
@mergify mergify bot merged commit 5258922 into flux-framework:master Apr 6, 2022
@dongahn
Copy link
Member

dongahn commented Apr 6, 2022

I think these tests are repeated lower down against the rv1 reader but I could be mistaken.

Could be. When I added this, there were no ID mapping tests for GPU IDs and stuff. Maybe that's sufficiently covered now?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge-when-passing mergify.io - merge PR automatically once CI passes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

hwloc reader uses resource.get-xml RPC which is scheduled for removal
2 participants