Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(all): use GH Action setup-flutter to install Flutter instead of custom script #3479

Merged
merged 10 commits into from
Feb 14, 2025

Conversation

miquelbeltran
Copy link
Member

@miquelbeltran miquelbeltran commented Feb 14, 2025

Description

Seems that CI installs of Flutter, by cloning the main repo, are currently broken. See flutter/flutter#163198

Switching to use the https://github.com/flutter-actions/setup-flutter action instead of our custom install script, as the process seems now more complex.

Related Issues

Related: flutter/flutter#163198

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I titled the PR using Conventional Commits.
  • I did not modify the CHANGELOG.md nor the plugin version in pubspec.yaml files.
  • All existing and new tests are passing.
  • The analyzer (flutter analyze) does not report any problems on my PR.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate that with a ! in the title as explained in Conventional Commits).
  • No, this is not a breaking change.

@miquelbeltran miquelbeltran marked this pull request as draft February 14, 2025 12:24
@miquelbeltran miquelbeltran changed the title ci: Fixing CI ci(all): use GH Action setup-flutter to install Flutter instead of custom script Feb 14, 2025
@miquelbeltran miquelbeltran marked this pull request as ready for review February 14, 2025 12:58
@miquelbeltran
Copy link
Member Author

Going ahead and merging this since the CI is completely broken otherwise and it stops other PRs

@miquelbeltran miquelbeltran merged commit f4c49bd into main Feb 14, 2025
102 of 117 checks passed
@miquelbeltran miquelbeltran deleted the fix-ci branch February 14, 2025 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant