Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate embedded DartPad editors away from multi-file #9898

Closed
johnpryan opened this issue Dec 6, 2023 · 5 comments · Fixed by #9908
Closed

Migrate embedded DartPad editors away from multi-file #9898

johnpryan opened this issue Dec 6, 2023 · 5 comments · Fixed by #9908
Assignees
@parlough
Labels
fix.copy Needs copy editing from.team Reported by Dash docs team member infra.dartpad Relates to DartPad component code or functionality infra.structure Relates to the tools that create docs.flutter.dev p1-high Major but not urgent concern: Resolve in months. Update each month.

Comments

@johnpryan
Copy link
Contributor

Describe the problem

We need to remove any content that uses DartPad's editable test code features so that they are ready to migrate to the new preview.dartpad.dev editor.

Expected fix

Pages that use embedded DartPads:

Pages that mention DartPad workshops:

On which platform(s) did you experience this issue?

No response

Additional context

See also: dart-lang/site-www#5382
@johnpryan johnpryan added infra.structure Relates to the tools that create docs.flutter.dev infra.dartpad Relates to DartPad component code or functionality labels Dec 6, 2023
@atsansone
Copy link
Contributor

@johnpryan : Could use some clarity for this issue. Do you want the embedded DartPad removed on these pages? If it appears on other pages, should we remove them there, too? With the pages that mention DartPad, we should remove the mention?

Thanks!

@atsansone atsansone added fix.copy Needs copy editing st.triage.ltw act.wait-for-customer Needs response from customer from.team Reported by Dash docs team member labels Dec 6, 2023
@parlough
Copy link
Member

parlough commented Dec 6, 2023 •
edited
Loading

I think I've removed the remaining use cases of multi-file support already (on docs.flutter.dev), but if someone wants to double check, please do so!

The mentions to workshops will have to be removed though.

@parlough parlough self-assigned this Dec 6, 2023
@parlough parlough added the p1-high Major but not urgent concern: Resolve in months. Update each month. label Dec 6, 2023
@johnpryan
Copy link
Contributor Author

Tony, I shared the migration plan with you at go/dartpad-frontend-migration-plan.

I haven't verified that the test code features have been removed, so I filed this issue to be safe, but if none of them are using these features we should be fine to close this issue.

@github-actions github-actions bot removed the act.wait-for-customer Needs response from customer label Dec 6, 2023
@atsansone
Copy link
Contributor

That works. Thanks @johnpryan !

@parlough
Copy link
Member

parlough commented Dec 6, 2023

I'll do another pass to make sure and handle any other remaining uses and workshop mentions. Thanks for filing the issue John!

@parlough parlough mentioned this issue Dec 9, 2023
Merged
sfshaza2 pushed a commit that referenced this issue Dec 11, 2023
@parlough
Remove workshop mentions from codelab page (#9908)
7d95c26 
Closes #9898

The blog post here links to a few **great** community workshops.
Unfortunately some of them are no longer live, others have errors or a
bunch of lint warnings, and the feature is not guaranteed to continue in
its current form.
atsansone pushed a commit to atsansone/website that referenced this issue Dec 12, 2023
@parlough
Remove workshop mentions from codelab page (flutter#9908)
557e556 
Closes flutter#9898

The blog post here links to a few **great** community workshops.
Unfortunately some of them are no longer live, others have errors or a
bunch of lint warnings, and the feature is not guaranteed to continue in
its current form.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@parlough parlough

Labels
fix.copy Needs copy editing from.team Reported by Dash docs team member infra.dartpad Relates to DartPad component code or functionality infra.structure Relates to the tools that create docs.flutter.dev p1-high Major but not urgent concern: Resolve in months. Update each month.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove workshop mentions from codelab page flutter/website
3 participants
@atsansone @johnpryan @parlough