This repository has been archived by the owner on Feb 22, 2023. It is now read-only.
[camera] Use startVideoCapturing and expose concurrent stream/record #6815
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This uses the new startVideoCapturing implementation, that supports concurrent stream/record.
adam-harwood
changed the title
|
The checks will pass once a new version of |
|
It happens automatically once post-submit tests finish running, so normally it would have happened yesterday, but there was some post-submit test flake that we didn't notice. I'm re-running those now. |
|
I hit some CI snags with autopublish, but I've now published them manually. Sorry for the delay! |
bparrishMines
approved these changes
Dec 27, 2022
|
Looking forward to have this merged, awesome job @adam-harwood ! |
|
Dude， I am reeeeally looking forward to this feature. Can't wait for this PR to be released. Big thanks for your effort. |
stuartmorgan
approved these changes
Jan 17, 2023
|
Done, ready for merge I think @stuartmorgan . |
stuartmorgan
approved these changes
Jan 18, 2023
stuartmorgan
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 18, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jan 18, 2023
* 6ef1bc1da Roll Flutter from 8c2fdb8 to cc7845e (2 revisions) (flutter/plugins#6983) * 56ab33fd1 [shared_pref]: Bump mockito-inline (flutter/plugins#6976) * e85e0f28f [camera] Allow logical cameras to use all physical cameras via zoom on android 11+ (flutter/plugins#6150) * 11361d010 [camera] Use startVideoCapturing and expose concurrent stream/record (flutter/plugins#6815)
gspencergoog
pushed a commit
to gspencergoog/flutter
that referenced
this pull request
Jan 19, 2023
…#118682) * 6ef1bc1da Roll Flutter from 8c2fdb8 to cc7845e (2 revisions) (flutter/plugins#6983) * 56ab33fd1 [shared_pref]: Bump mockito-inline (flutter/plugins#6976) * e85e0f28f [camera] Allow logical cameras to use all physical cameras via zoom on android 11+ (flutter/plugins#6150) * 11361d010 [camera] Use startVideoCapturing and expose concurrent stream/record (flutter/plugins#6815)
mauricioluz
pushed a commit
to mauricioluz/plugins
that referenced
this pull request
Jan 26, 2023
…lutter#6815) * Use startVideoCapturing and expose concurrent stream/record This uses the new startVideoCapturing implementation, that supports concurrent stream/record. * Ran dart formatter * retrigger checks * Account for version bump
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses the new startVideoCapturing implementation, that supports concurrent stream/record.
This is the final piece from #6808.
Closes flutter/flutter#83634
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the [pub versioning philosophy], or this PR is [exempt from version changes].CHANGELOG.mdto add a description of the change, [following repository CHANGELOG style].///).